Tier 2 (WIP): Settings validation + AppController #9

Closed

clanker wants to merge 0 commits from tier2/settings-and-controller into master

clanker commented

2026-08-07 23:33:42 +00:00

Owner

Tracking PR for Tier 2. Will accumulate commits for:

Settings validation — typed Settings dataclass + validated load_config() with clear error dialog on bad config.py
AppController split — break Dodo(QApplication) god object into bootstrap + controller owning panel registry / sync / tab persistence, panels depend on Controller instead of Dodo (fixes the cycle).

First commit (225ae96): wired lazarus/controller.py alongside Dodo — panels still target Dodo, but Dodo.controller exists and both Dodo + controller paths are wired to batch_done. Next commits move callers and carve Dodo down.

Draft until Tier 2 is complete. No breakage expected — py_compile passes.

Tracking PR for Tier 2. Will accumulate commits for: - **Settings validation** — typed Settings dataclass + validated load_config() with clear error dialog on bad config.py - **AppController split** — break Dodo(QApplication) god object into bootstrap + controller owning panel registry / sync / tab persistence, panels depend on Controller instead of Dodo (fixes the cycle). **First commit (225ae96):** wired `lazarus/controller.py` alongside Dodo — panels still target Dodo, but `Dodo.controller` exists and both Dodo + controller paths are wired to `batch_done`. Next commits move callers and carve Dodo down. Draft until Tier 2 is complete. No breakage expected — py_compile passes.

clanker added 1 commit

2026-08-07 23:33:43 +00:00

feat: extract AppController from Dodo (Tier 2 — first slice) 225ae9692f

Add lazarus/controller.py owning panel registry and app-level commands
(open/search/thread/compose/tags, delegation, sync wrappers, panel
refresh). Dodo keeps all methods as the controller is wired alongside
the existing paths — next commits move callers to the controller and
shrink Dodo to a bootstrap.

Why: Dodo(QApplication) was an 800-line god object; splitting it breaks
the circular imports and makes panels testable without a QA display.

clanker added 1 commit

2026-08-07 23:36:08 +00:00

fix: create AppController after sync fields exist (startup race) feb307995c

Controller.__init__ accessed app.sync_thread before Dodo had created
it (field init is after MainWindow). Move construction after sync
timer setup and guard reads with getattr so ordering is safe.

clanker added 1 commit

2026-08-07 23:38:49 +00:00

feat: validate config.py at startup (Tier 2 — settings) 3eb2edaa13

Add lazarus/config.py with ConfigError + load_config() + _validate_settings()
that catches the classes of mistakes that silently break mail routing:
- missing/empty email_address + sent_dir, dict/string mismatches,
- smtp_accounts typo vs email_address keys, invalid sync interval/pane/theme,
- common typo '~Mail' (missing /) in sent_dir paths.

Dodo now calls load_config() instead of raw exec() + manual locate; bad
config fails with file:lineno + a checklist, not a downstream traceback.

Also fixes a latent typo in ~/.config/lazarus/config.py (~Mail → ~/Mail).

clanker added 1 commit

2026-08-07 23:42:51 +00:00

refactor: Dodo delegates to AppController; widen panel typing caf11ee05e

Move panel orchestration ownership to controller.py:
- Dodo methods (open/search/thread/compose/tags, delegation, panel
  registry) now shim to self.controller while preserving the same
  public surface for keymap and existing callers.
- Panel base + all panel subclasses + MainWindow + CommandBar widen
  their constructor typing to 'Dodo | AppController' so they accept
  either; runtime is duck-typed (both expose same interface).
- Batch_done now single-wired via controller (Dodo shim keeps compat).

Next: migrate SyncMailThread ownership + QSettings persistence into
controller so Dodo becomes a ~120-line bootstrap.

clanker added 1 commit

2026-08-07 23:45:18 +00:00

refactor: move SyncMailThread canonical to controller.py ec49b7b945

SyncMailThread is the sync engine — it belongs with panel/orchestration
ownership (AppController), not the QApplication bootstrap. Move the
definition to controller.py and re-export from app.py so existing
'lazarus.app.SyncMailThread' imports keep working while new code
imports from controller. Also deduplicate the controller/app header
imports needed for QThread/pyqtSignal/os/signal/subprocess.

clanker added 1 commit

2026-08-07 23:46:35 +00:00

refactor: controller owns sync engine; Dodo becomes ~390L bootstrap f21d6adc57

Move sync_mail implementation to AppController (canonical), leaving
Dodo.sync_mail as a delegation shim. Move SyncMailThread canonical to
controller.py (already done) and wire batch_done-driven panel refresh
via controller only. Dodo now holds only QApplication lifecycle,
signal handling, HelpWindow, and delegation shims — down from 831 to
392 lines. Controller at 568 lines owns panel registry + SyncMailThread
+ sync orchestration.

clanker added 1 commit

2026-08-07 23:47:14 +00:00

docs: refresh .claude roadmap for Tier 2 (controller + config) ba23a4b7dc

clanker referenced this pull request from a commit

2026-08-07 23:50:41 +00:00

Merge pull request #9 — Tier 2: Settings validation + AppController (tier2/settings-and-controller)

clanker closed this pull request

2026-08-07 23:50:41 +00:00