refactor(controller,settings): clean up vestigial sync and config references #72

Merged

clanker merged 1 commit from pr/cleanup-ned-separation into main

2026-09-06 02:36:56 +00:00

clanker commented

2026-09-06 02:34:09 +00:00

Member

Overview

Cleans up remaining vestigial references, dead branches, and outdated documentation following the separation of core Lazarus functionality into the standalone NED package.

Changes

Lazarus controller (lazarus/controller.py):
- Removed unused self.notmuch_rc and self.notmuch_stderr attributes from SyncMailThread.
- Removed the dead elif t.notmuch_rc != 0: error handling branch in _cleanup_sync.
- Updated sync_mail docstring to document delegation to NED's POST /api/v1/sync.
Lazarus settings (lazarus/settings.py):
- Removed obsolete (REQUIRED) labels on email_address and sent_dir docstrings. Clarified that mail identity and routing live in ~/.config/ned/config.py.
- Updated filter_rules and filter_scope_query docstrings to clarify daemon-side configuration and execution.
NED docstrings (ned/notmuch.py, ned/rules.py, ned/util.py):
- Replaced stale cross-package references to lazarus.settings and lazarus.controller with ned.settings, ned.sync, and ned.service.
- Updated email_is_me and email_smtp_account_index docstrings to refer generically to compose clients.
Test suite consistency:
- Renamed tests/test_core_actions.py to tests/test_ned_actions.py and tests/test_core_sync.py to tests/test_ned_sync.py.
- Renamed test function test_core_worker_lifecycle to test_ned_worker_lifecycle.
Package build specifications (setup.py, ned/setup.py):
- Replaced deprecated setuptools license classifiers with standard license="GPL-3.0-or-later" expression to eliminate build warnings.

Verification

Type check: uvx --with PyQt6 --with PyQt6-WebEngine mypy lazarus ned passed with zero errors across 56 files.
Linter: uvx pyflakes lazarus ned passed cleanly.
Test suite: ~/.local/share/pipx/venvs/lazarus-mail/bin/python -m pytest passed all 437 tests.
Package build: uv build --directory ned completed with zero warnings.

## Overview Cleans up remaining vestigial references, dead branches, and outdated documentation following the separation of core Lazarus functionality into the standalone NED package. ## Changes 1. **Lazarus controller** (`lazarus/controller.py`): - Removed unused `self.notmuch_rc` and `self.notmuch_stderr` attributes from `SyncMailThread`. - Removed the dead `elif t.notmuch_rc != 0:` error handling branch in `_cleanup_sync`. - Updated `sync_mail` docstring to document delegation to NED's `POST /api/v1/sync`. 2. **Lazarus settings** (`lazarus/settings.py`): - Removed obsolete `(REQUIRED)` labels on `email_address` and `sent_dir` docstrings. Clarified that mail identity and routing live in `~/.config/ned/config.py`. - Updated `filter_rules` and `filter_scope_query` docstrings to clarify daemon-side configuration and execution. 3. **NED docstrings** (`ned/notmuch.py`, `ned/rules.py`, `ned/util.py`): - Replaced stale cross-package references to `lazarus.settings` and `lazarus.controller` with `ned.settings`, `ned.sync`, and `ned.service`. - Updated `email_is_me` and `email_smtp_account_index` docstrings to refer generically to compose clients. 4. **Test suite consistency**: - Renamed `tests/test_core_actions.py` to `tests/test_ned_actions.py` and `tests/test_core_sync.py` to `tests/test_ned_sync.py`. - Renamed test function `test_core_worker_lifecycle` to `test_ned_worker_lifecycle`. 5. **Package build specifications** (`setup.py`, `ned/setup.py`): - Replaced deprecated setuptools license classifiers with standard `license="GPL-3.0-or-later"` expression to eliminate build warnings. ## Verification - Type check: `uvx --with PyQt6 --with PyQt6-WebEngine mypy lazarus ned` passed with zero errors across 56 files. - Linter: `uvx pyflakes lazarus ned` passed cleanly. - Test suite: `~/.local/share/pipx/venvs/lazarus-mail/bin/python -m pytest` passed all 437 tests. - Package build: `uv build --directory ned` completed with zero warnings.

clanker added 1 commit

2026-09-06 02:34:10 +00:00

refactor(controller,settings): clean up vestigial sync and config references cedccd7d21

clanker merged commit 4d494638b2 into main

2026-09-06 02:36:56 +00:00

clanker referenced this pull request from a commit

2026-09-06 02:36:58 +00:00

Merge pull request 'refactor(controller,settings): clean up vestigial sync and config references' (#72) from pr/cleanup-ned-separation into main