Home/lazarus
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleanup and Dead Code Removal #4

Closed
clanker wants to merge 0 commits from fix/cleanup-dead-code into master
pull from: fix/cleanup-dead-code
merge into: Home:master
Conversation 0 Commits - Files changed -
clanker commented 2026-07-24 20:22:52 +00:00
Owner
Copy link

Fixes

17. Remove dead ThreadPanel methods

delete_message() and archive_to_local() in ThreadPanel were never wired to any keybinding. Delete/archive operations in thread view are handled by the global keymap which delegates to the current list panel. Removed both methods and the now-unused actions import.

18. Fix typo in commandbar.py

ingnore -> ignore

26. Deduplicate DashboardModel row-building

Extracted _rebuild_rows() method shared by refresh() and _rebuild_from_sections() to eliminate the duplicate 8-line row assembly code.

Files Changed

  • dodo/thread.py: Remove dead methods and unused import
  • dodo/commandbar.py: Fix typo
  • dodo/dashboard.py: Extract _rebuild_rows(), deduplicate

Testing

  • Delete/archive from thread view continue to work via global keymap
  • Dashboard refresh and single-thread refresh produce identical rows
  • No import errors
## Fixes ### 17. Remove dead ThreadPanel methods `delete_message()` and `archive_to_local()` in `ThreadPanel` were never wired to any keybinding. Delete/archive operations in thread view are handled by the global keymap which delegates to the current list panel. Removed both methods and the now-unused `actions` import. ### 18. Fix typo in commandbar.py `ingnore` -> `ignore` ### 26. Deduplicate DashboardModel row-building Extracted `_rebuild_rows()` method shared by `refresh()` and `_rebuild_from_sections()` to eliminate the duplicate 8-line row assembly code. ## Files Changed - `dodo/thread.py`: Remove dead methods and unused import - `dodo/commandbar.py`: Fix typo - `dodo/dashboard.py`: Extract _rebuild_rows(), deduplicate ## Testing - Delete/archive from thread view continue to work via global keymap - Dashboard refresh and single-thread refresh produce identical rows - No import errors
- Remove dead delete_message() and archive_to_local() from ThreadPanel
  (these were superseded by global keymap delegation to list panels) (#17)

- Remove unused 'actions' import from thread.py

- Fix typo 'ingnore' -> 'ignore' in commandbar.py (#18)

- Extract _rebuild_rows() to eliminate duplicate row-building code
  between DashboardModel.refresh() and _rebuild_from_sections() (#26)
RulyTafzil closed this pull request 2026-07-24 20:37:33 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Home/lazarus!4
No description provided.