refactor: performance, maintainability, and filter cleanup #58

Merged

clanker merged 3 commits from refactor/perf-and-cleanup into main

2026-09-07 17:54:32 +00:00

clanker commented

2026-09-03 17:18:11 +00:00

Member

Summary of changes

Filter pills and active group cleanup: Removed all vestigial filter pills, active group state tracking, and unused prop drilling across PageFilterBar, useCardFilter, ClassView, SphereView, FeatView, GearPageView, MartialTraditionsView, CastingTraditionsView, UsingPageView, and CoreArchetype views.
Duplicate card scoring elimination: Stopped passing full card collections as filter groups to useCardFilter in ClassView and SphereView. Both views now feed additionalItems for tag indexing without redundant group scoring passes.
Homepage client bundle reduction: Converted app/page.tsx into a Server Component by extracting the command palette launcher button into a client component (SearchPromptButton). The 11 JSON catalog indexes are rendered on the server instead of bundled in client JavaScript.
NotebookContext optimizations: Switched isPinned lookups to an O(1) Set lookup, memoized the provider context value, and removed dead custom group functions.
Client navigation in CommandPalette: Replaced window.location reloads with Next.js router.push to maintain client state.
Unified link preview resolution: Updated fetchContent in useLinkPreview to use resolveContentFromPage.
Badge logic deduplication: Extracted progression and modifier badge resolution into shared helpers in tagStyles.ts.
ArchetypeCard search expansion: Auto-expands matching features when active tag filters are present.
SidebarTOC scroll throttling: Added requestAnimationFrame throttling to scrollspy handler.

Verification

Audit script (python3 scripts/audit.py): 0 errors.
Production build (vercel build --prod): clean build, 481 static pages generated.
Production deployment: deployed to https://spheres4dummies.vercel.app with --archive=tgz.

## Summary of changes - **Filter pills and active group cleanup**: Removed all vestigial filter pills, active group state tracking, and unused prop drilling across PageFilterBar, useCardFilter, ClassView, SphereView, FeatView, GearPageView, MartialTraditionsView, CastingTraditionsView, UsingPageView, and CoreArchetype views. - **Duplicate card scoring elimination**: Stopped passing full card collections as filter groups to useCardFilter in ClassView and SphereView. Both views now feed additionalItems for tag indexing without redundant group scoring passes. - **Homepage client bundle reduction**: Converted app/page.tsx into a Server Component by extracting the command palette launcher button into a client component (SearchPromptButton). The 11 JSON catalog indexes are rendered on the server instead of bundled in client JavaScript. - **NotebookContext optimizations**: Switched isPinned lookups to an O(1) Set lookup, memoized the provider context value, and removed dead custom group functions. - **Client navigation in CommandPalette**: Replaced window.location reloads with Next.js router.push to maintain client state. - **Unified link preview resolution**: Updated fetchContent in useLinkPreview to use resolveContentFromPage. - **Badge logic deduplication**: Extracted progression and modifier badge resolution into shared helpers in tagStyles.ts. - **ArchetypeCard search expansion**: Auto-expands matching features when active tag filters are present. - **SidebarTOC scroll throttling**: Added requestAnimationFrame throttling to scrollspy handler. ## Verification - Audit script (python3 scripts/audit.py): 0 errors. - Production build (vercel build --prod): clean build, 481 static pages generated. - Production deployment: deployed to https://spheres4dummies.vercel.app with --archive=tgz.

clanker added 1 commit

2026-09-03 17:18:12 +00:00

refactor: performance, maintainability, and filter cleanup 4e4e5b623d

- Remove unused filter pills and vestigial activeGroup logic across all views and hooks
- Eliminate duplicate card scoring passes in ClassView and SphereView
- Convert homepage to a Server Component with SearchPromptButton client launcher
- Optimize NotebookContext with O(1) Set lookup for isPinned, memoized value, and dead code cleanup
- Switch CommandPalette navigation to Next.js useRouter
- Unify link preview content resolution in useLinkPreview
- Deduplicate progression and modifier badge resolution in tagStyles
- Auto-expand ArchetypeCard features on active tag match
- Throttle SidebarTOC scroll listener with requestAnimationFrame

clanker added 1 commit

2026-09-03 17:27:48 +00:00

feat: make class and sphere ToC expandable with subitems 412ac76ffc

- Add hierarchical subitem generation in ClassView and SphereView for features, talent groups, option groups, feats, drawbacks, rules, and archetypes
- Default all expandable ToC sections to collapsed state
- Add hash anchor ancestor expansion on mount in SidebarTOC
- Align talent group section anchors for deep linking and scrollspy

clanker added 1 commit

2026-09-07 17:54:23 +00:00

fix(toc): handle unmounted targets on jump and anchor archetype option groups 7d2ba6ca99

clanker merged commit 12b6d43772 into main

2026-09-07 17:54:32 +00:00

clanker referenced this pull request from a commit

2026-09-07 17:54:33 +00:00

Merge pull request 'refactor: performance, maintainability, and filter cleanup' (#58) from refactor/perf-and-cleanup into main